Skip to content

Fix staticcheck lint errors #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix staticcheck lint errors #39

wants to merge 1 commit into from

Conversation

@harche
Copy link

@harche harche commented Oct 1, 2025

Summary

  • Fix embedded field selector issues (QF1008) by removing redundant embedded field qualifiers
  • Fix duplicate package imports (ST1019) by consolidating kubernetes package imports to use internalk8s alias consistently
  • All tests pass successfully after changes

Changes

  • pkg/mcp/common_test.go: Remove McpClient qualifier from Close() call
  • pkg/mcp/mcp.go: Remove StaticConfig qualifiers for ReadOnly, DisableDestructive, EnabledTools, DisabledTools, and RequireOAuth fields
  • pkg/mcp/toolsets_test.go: Remove MockServer qualifier from KubeconfigFile() call
  • pkg/toolsets/core/namespaces.go: Remove duplicate kubernetes import, use internalk8s alias exclusively
  • pkg/toolsets/core/resources.go: Remove duplicate kubernetes import, use internalk8s alias exclusively

Test plan

  • make lint passes with 0 issues
  • make test passes all tests
  • go test -v ./pkg/mcp/... passes all MCP tests

🤖 Generated with Claude Code

@harche @claude
Fix staticcheck lint errors
2b16a89 
Remove embedded field selectors and duplicate package imports to resolve
all staticcheck warnings reported by golangci-lint.

Changes:
- Remove embedded field selectors (QF1008) in favor of direct field access
- Remove duplicate kubernetes package imports (ST1019) in favor of internalk8s alias
- Update all references to use the aliased import consistently

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@openshift-ci openshift-ci bot requested a review from ardaguclu October 1, 2025 23:58
@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harche
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harche
Copy link
Author

harche commented Oct 1, 2025

all tests pass.

/hold to test using real OCP cluster.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2025

@harche: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2b16a89 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This was referenced Oct 2, 2025
Open
Closed
@harche
Copy link
Author

harche commented Oct 2, 2025

ci/prow/security job failures are not related to this PR, they are tracked in #40

@manusa
Copy link

manusa commented Oct 2, 2025

Were already addressed here: containers#344

In case anything is missing, we should fix them upstream first.

@harche
Copy link
Author

harche commented Oct 2, 2025

Were already addressed here: containers#344

In case anything is missing, we should fix them upstream first.

sure thanks.

/close

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2025

@harche: Closed this PR.

In response to this:

Were already addressed here: containers#344

In case anything is missing, we should fix them upstream first.

sure thanks.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Oct 2, 2025
@harche harche deleted the fix-lint-errors branch October 2, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harche @manusa